Convert more tests to use TestEnv #9131
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
commented
Jan 24, 2026
| } | ||
|
|
||
| func (s *UserMetadataSuite) TestUserMetadata() { | ||
| getDescribeWorkflowExecutionInfo := func(client workflowservice.WorkflowServiceClient, namespace string, workflowID string, runID string) (*workflowservice.DescribeWorkflowExecutionResponse, error) { |
Contributor
Author
There was a problem hiding this comment.
Inlined this, it's pretty short.
stephanos
commented
Jan 24, 2026
|
|
||
| } | ||
|
|
||
| func (b *sutConnector) startWorkflowExecution(ns namespace.Name) error { |
Contributor
Author
There was a problem hiding this comment.
inlined all these helpers; much easier to follow ...
stephanos
force-pushed
the
test-env-5
branch
2 times, most recently
from
d73ebde to
17401d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Describe what has changed in this PR.
Why?
Tell your future self why have you made these changes.
How did you test it?
Potential risks
Any change is risky. Identify all risks you are aware of. If none, remove this section.