Skip to content

Conversation

@stephanos
Copy link
Contributor

@stephanos stephanos commented Jan 26, 2026

What changed?

Adds and integrates yamlfmt (Go-based, by Google).

Anything not annotated was changed by yamlfmt.

Why?

Consistent YAML formatting. Reduce unrelated diffs caused by formatting in PRs.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Copy link
Contributor Author

@stephanos stephanos Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change 3/3: targets to install and run yamlfmt

Copy link
Contributor Author

@stephanos stephanos Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change 1/3: Configure yamlfmt

about the options

  • retain_line_breaks:: empty lines are reasonable IMO; we have lots of them
  • force_quote_style: most existing use double, least amount of changes

- lint-protos
- lint-actions
- fmt-imports
- lint-yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change 2/3: invoke yamlfmt linter in CI

@stephanos stephanos force-pushed the yamlfmt branch 3 times, most recently from cdae60c to 0f1c663 Compare January 26, 2026 22:10
@stephanos stephanos marked this pull request as ready for review January 26, 2026 22:55
@stephanos stephanos requested review from a team as code owners January 26, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant