Skip time in UpdateWorkflowSuite [WiP] #9145
Draft
+395
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
manual-faults3
branch
3 times, most recently
from
12c3393 to
d58fd6d
Compare
stephanos
changed the title
stephanos
force-pushed
the
manual-faults3
branch
5 times, most recently
from
8b69955 to
59d2130
Compare
stephanos
force-pushed
the
manual-faults3
branch
from
59d2130 to
de785a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replaced all "real time"
timepackage uses withclock.TimeSourceacross History and Matching.Why?
To replace
time.Sleeps withs.AdvanceinUpdateWorkflowSuiteto skip time; one for History, one for Matching.Before: TBD
After: TBD
How did you test it?
Tests were run 10x locally without issues.
Potential risks
Any change is risky. Identify all risks you are aware of. If none, remove this section.