-
Notifications
You must be signed in to change notification settings - Fork 10
change time datatypes to builtin int128 #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/limited_datatypes
Are you sure you want to change the base?
Conversation
|
liss-h
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a little more context to the PR description? Like a summary of the changes and what the implications are (limits and such)
# Conflicts: # src/rdf4cpp/Timezone.hpp # src/rdf4cpp/datatypes/registry/util/DateTimeUtils.hpp
|
Note to self, review when 128bit integer PR is merged |


changes date/time 128 bit integer from boost to builtin
__int128, to make calculations a lot faster.while the builtin has a smaller range than boost, both are bigger than what the
int64_tyear allows. therefore the usable range of date/time types stays the same.also fixes some possible (but very unlikely in regular use) overflow errors in date/time calculations (to trigger them, you need to use very big numbers, at least several orders of magnitude bigger than the end of the universe).