Skip to content

decrease earliest epoch value of query xml by 3 hours query XML #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
elliVM wants to merge 11 commits into
base: main
Choose a base branch
from
Open

decrease earliest epoch value of query xml by 3 hours query XML #415

elliVM wants to merge 11 commits into from

Conversation

@elliVM
Copy link
Contributor

@elliVM elliVM commented Nov 14, 2024

Workaround to decrease earliest epoch value given to query XML by 3 hours to work with pth_06 that uses helsinki timezone.

@elliVM elliVM requested a review from eemhu November 14, 2024 13:42
@elliVM elliVM mentioned this pull request Nov 14, 2024
Open
@elliVM
Copy link
Contributor Author

elliVM commented Nov 14, 2024

For issues #83 and #401

@kortemik
Copy link
Member

kortemik commented Nov 14, 2024

please rebase

@elliVM elliVM force-pushed the timestamp-epoch-minus-three-hours branch from 1551c09 to bfeceed Compare November 15, 2024 09:39
@elliVM
Copy link
Contributor Author

elliVM commented Nov 15, 2024

Rebased

@eemhu
Copy link
Contributor

eemhu commented Nov 15, 2024

I think you also need to change it for the produced XML and spark column to have an effect

@elliVM elliVM requested a review from 51-code November 15, 2024 11:33
@elliVM elliVM marked this pull request as draft November 15, 2024 11:34
@elliVM elliVM marked this pull request as ready for review November 18, 2024 08:06
@elliVM elliVM requested a review from eemhu November 18, 2024 08:06
@elliVM elliVM mentioned this pull request Nov 18, 2024
Closed
51-code
51-code suggested changes Nov 18, 2024
View reviewed changes
@elliVM elliVM requested a review from 51-code November 18, 2024 13:06
51-code
51-code approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eemhu
eemhu reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@eemhu eemhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should EqualsVerifier be added to pth-10 as well for hashCode tests?

@kortemik
Copy link
Member

kortemik commented Nov 20, 2024

LGTM, but should EqualsVerifier be added to pth-10 as well for hashCode tests?

yes, please add @elliVM

kortemik
kortemik requested changes Nov 20, 2024
View reviewed changes
@elliVM
Copy link
Contributor Author

elliVM commented Nov 20, 2024

Added EqualsVerifier library and contract test.

@elliVM elliVM requested a review from kortemik November 20, 2024 10:48
@kortemik kortemik requested review from 51-code and eemhu November 20, 2024 10:55
eemhu
eemhu approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@eemhu eemhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

51-code
51-code approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliVM elliVM force-pushed the timestamp-epoch-minus-three-hours branch from 94ee229 to 351832d Compare January 21, 2025 12:40
@elliVM
Copy link
Contributor Author

elliVM commented Jan 21, 2025

Rebased and duplicate dependency removed

@kortemik kortemik mentioned this pull request Nov 14, 2023
Closed
kortemik
kortemik requested changes Apr 24, 2025
View reviewed changes
src/main/java/com/teragrep/pth10/ast/commands/logicalstatement/TimeStatement.java Outdated
);
final ElementNode returnValue;
if (timeQualifier.isStartTime()) {
final long decreaseValue = 3 * 60 * 60 * 1000; // decrease 3 hours from earliest
Copy link
Member

@kortemik kortemik Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make this configurable:

dpl.pth_10.logicalstatement.TimeStatement.xmlDecreaseStartTime=true

check that all paths parts to the key are defined as this is an optional key i.e.
hasKey(dpl.pth_10.logicalstatement) && hasKey(dpl.pth_10.logicalstatement.TimeStatement) && hasKey(dpl.pth_10.logicalstatement.TimeStatement.xmlDecreaseStartTime)

@elliVM elliVM force-pushed the timestamp-epoch-minus-three-hours branch from ccc94ba to 2319474 Compare May 19, 2025 06:53
@elliVM
Copy link
Contributor Author

elliVM commented May 19, 2025

rebased and update code, further changes required after #572

@elliVM elliVM force-pushed the timestamp-epoch-minus-three-hours branch from d509b51 to 5037b98 Compare June 12, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kortemik kortemik kortemik requested changes

@eemhu eemhu eemhu approved these changes

+1 more reviewer

@51-code 51-code 51-code approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@elliVM elliVM

@51-code 51-code

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elliVM @kortemik @eemhu @51-code