Skip to content

Conversation

@Abigael-JT
Copy link
Contributor

@Abigael-JT Abigael-JT commented Jan 24, 2025

  • Removed null assignment and redundant casting
  • Replaced commented out code in if statement with an exception
  • Returned NullNode instead of null
  • Added an exception to avoid a Null pointer exception if aggregation column is null

@Abigael-JT Abigael-JT requested a review from elliVM January 24, 2025 12:24
@Abigael-JT Abigael-JT changed the title removed null assignment and redundant casting, returned NullNode inst… issue_486 Jan 24, 2025
Copy link
Contributor

@elliVM elliVM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@Abigael-JT
Copy link
Contributor Author

changes made

@Abigael-JT Abigael-JT marked this pull request as ready for review January 28, 2025 10:59
@Abigael-JT Abigael-JT linked an issue Jan 28, 2025 that may be closed by this pull request
@Abigael-JT Abigael-JT requested a review from 51-code January 28, 2025 11:03
Copy link
Contributor

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about the exceptions.

@Abigael-JT
Copy link
Contributor Author

Removed unnecessary check and clarified exception message if the given command is not an aggregation function

@Abigael-JT Abigael-JT requested a review from 51-code January 29, 2025 10:29
@Abigael-JT Abigael-JT requested a review from 51-code January 29, 2025 11:04
Copy link
Contributor

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Abigael-JT Abigael-JT requested a review from kortemik January 29, 2025 12:46
@Abigael-JT Abigael-JT requested review from eemhu and removed request for kortemik April 1, 2025 13:22
@Abigael-JT Abigael-JT requested a review from eemhu April 15, 2025 13:28
Copy link
Member

@kortemik kortemik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catch of a NullPointerException is not allowable, use null check and throw a proper exception in case no argument is provided. i.e. IllegalArgumentException("required instruction x not provided");

@Abigael-JT
Copy link
Contributor Author

removed the try catch block and replaced it with null check that throws an exception in eventstats instructions are missing

@Abigael-JT Abigael-JT requested a review from kortemik April 30, 2025 10:17
@Abigael-JT
Copy link
Contributor Author

typo fixed

@Abigael-JT Abigael-JT requested a review from eemhu June 3, 2025 11:35
@Abigael-JT
Copy link
Contributor Author

rebased

@Abigael-JT Abigael-JT requested a review from eemhu September 1, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Method called on a null object in EventstatsTransformation class

5 participants