-
Notifications
You must be signed in to change notification settings - Fork 9
issue_486 #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
issue_486 #487
Conversation
elliVM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Show resolved
Hide resolved
|
changes made |
51-code
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about the exceptions.
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Outdated
Show resolved
Hide resolved
|
Removed unnecessary check and clarified exception message if the given command is not an aggregation function |
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Outdated
Show resolved
Hide resolved
51-code
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Outdated
Show resolved
Hide resolved
kortemik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catch of a NullPointerException is not allowable, use null check and throw a proper exception in case no argument is provided. i.e. IllegalArgumentException("required instruction x not provided");
|
removed the try catch block and replaced it with null check that throws an exception in eventstats instructions are missing |
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/EventstatsTransformation.java
Outdated
Show resolved
Hide resolved
|
typo fixed |
|
rebased |
Uh oh!
There was an error while loading. Please reload this page.