-
Notifications
You must be signed in to change notification settings - Fork 9
Adds wildcard support for fields command #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…iven fields, added wildcard tests for fields command
src/main/java/com/teragrep/pth_10/ast/commands/transformstatement/FieldsTransformation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth_10/ast/commands/transformstatement/FieldsTransformation.java
Outdated
Show resolved
Hide resolved
| public Node visitFieldType(DPLParser.FieldTypeContext ctx) { | ||
| String sql = ctx.getChild(0).getText(); | ||
| // if fields command has just a field mode and no field names | ||
| if (ctx.getChildCount() < 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this check necessary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it throws NPE otherwise
| } | ||
|
|
||
| @Test | ||
| public void testEquals() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use EqualsVerifier.forClass(FilteredColumns.class).verify() instead;
Description
Checklists
Testing
General
Assertions
Testing Data
Statements
Java
Other
Code Quality