Restore DNS hostname resolution for apt-proxy #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 17 broke DNS-based hostname resolution for 'apt-proxy'. The code now only checks /etc/hosts statically and no longer performs DNS lookups, breaking portable laptop configurations that rely on DNS search domains. This was inadvertently introduced in commit c2d0159 ("Check for explicitly configured proxies before trying the gateway") which refactored the detection flow but accidentally removed the DNS-resolving functions v4_explicit_proxy() and v6_explicit_proxy() from the detection sequence. This fix restores DNS hostname resolution by adding back the calls to v4_explicit_proxy and v6_explicit_proxy, while preserving the intent of c2d0159 to check explicit proxies before the gateway. The detection order is now: 1. Local running proxies (localhost, local addresses) 2. Container host 3. Explicitly configured proxies via /etc/hosts 4. Explicitly configured proxies via DNS hostname resolution (restored) 5. DNS SRV records 6. Avahi/mDNS 7. Network gateway This allows users with DNS search domains (e.g., 'search example.com' in /etc/resolv.conf) to resolve 'apt-proxy' via DNS again, enabling portable configurations that gracefully handle being away from the home network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 17 broke DNS-based hostname resolution for 'apt-proxy'. The code now only checks /etc/hosts statically and no longer performs DNS lookups, breaking portable laptop configurations that rely on DNS search domains.
This was inadvertently introduced in commit c2d0159 ("Check for explicitly configured proxies before trying the gateway") which refactored the detection flow but accidentally removed the DNS-resolving functions v4_explicit_proxy() and v6_explicit_proxy() from the detection sequence.
This fix restores DNS hostname resolution by adding back the calls to v4_explicit_proxy and v6_explicit_proxy, while preserving the intent of c2d0159 to check explicit proxies before the gateway.
The detection order is now:
This allows users with DNS search domains (e.g., 'search example.com' in /etc/resolv.conf) to resolve 'apt-proxy' via DNS again, enabling portable configurations that gracefully handle being away from the home network.