Add integration tests, observability, and STARTTLS support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terraboops
changed the title
- Add tracing instrumentation with spans throughout server code - Add Prometheus metrics (connections, auth, stanzas, errors, latencies) - Add XML trace logging (CHATTERMAX_XML_TRACE env var) - Create comprehensive system test suite with 19 integration tests: - Connection and stream negotiation tests - SASL authentication tests (PLAIN) - Resource binding and session establishment - Protocol tests (ping, disco, roster) - Conversations-compatible login sequence test - Fix self-closing XML tag extraction in stream parser - Add GitHub Actions CI workflow https://claude.ai/code/session_01LFGkff9HGRZ2yerQcB5BoF
- Run cargo fmt to fix formatting - Rename from_str() methods to parse() in stanza.rs to avoid clippy warning - Use as_deref() instead of as_ref().map() in db.rs - Iterate over map values directly in muc.rs - Add #[allow(dead_code)] for unused test helper methods - Use io::Error::other() instead of io::Error::new(ErrorKind::Other, ...) - Remove unused import PathBuf https://claude.ai/code/session_01LFGkff9HGRZ2yerQcB5BoF
- Rename tests/system.rs to tests/integration.rs to clarify purpose - Integration tests verify protocol correctness with a minimal test client - Add scripts/e2e-test.sh for end-to-end testing with real XMPP clients (go-sendxmpp or sendxmpp) to validate real-world compatibility - Update CI workflow to reference renamed test file The integration tests ensure protocol compliance, while e2e tests validate that real third-party XMPP clients can connect and operate. https://claude.ai/code/session_01LFGkff9HGRZ2yerQcB5BoF
- Update e2e-test.sh to support multiple XMPP clients: - go-sendxmpp (preferred) - sendxmpp (Perl) - python3-slixmpp (fallback, used in CI) - Add embedded Python test script using slixmpp for non-TLS connections - Add e2e job to CI that: - Installs python3-slixmpp via apt - Runs the e2e test script against a real server instance - E2E tests validate real client compatibility, not just protocol correctness https://claude.ai/code/session_01LFGkff9HGRZ2yerQcB5BoF
- Add TLS module with MaybeT stream wrapper for plain/TLS connections - Rewrite stream handling to use byte-level reading instead of line-based (real XMPP clients don't send newlines between stanzas) - Add add_default_namespace() to inject xmlns='jabber:client' into stanzas (required for proper minidom parsing) - Track TLS state in Session for feature negotiation - Simplify e2e tests to use go-sendxmpp with proper TLS skip flag Tested with go-sendxmpp and Android Conversations app.
- Add TlsConfig struct to config module - Add get_room_messages() to database for MUC message history - Fix test harness to match updated Router::new signature
terraboops
force-pushed
the
claude/xmpp-tests-observability-KeStD
branch
from
0ae403d to
b8243be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/metricson configurable port)Changes
Observability
Testing
tests/integration.rs): In-process tests covering authentication, roster, presence, messaging, MUC, and MAMscripts/e2e-test.sh): Uses go-sendxmpp to test against a running server with real TLSSTARTTLS Support
tls.rsmodule withMaybeTstream wrapper for plain/TLS connectionsTlsConfigin configuration for cert/key pathsMUC Enhancements
get_room_messages()for MUC message archive queries (MAM)CI
Test plan
cargo test- 19 integration tests passcargo clippy- no warningscargo fmt --check- properly formatted