forked from jeremychone/rust-genai
-
Notifications
You must be signed in to change notification settings - Fork 0
Merge upstream changes and consolidate Z.AI adapter #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave the fn_arguments parsed
…eremychone#95) - Rename zhipu adapter to zai adapter - Implement namespace-based routing for regular vs coding endpoints - Regular models: "glm-4.6" → credit-based API - Coding models: "zai::glm-4.6" → subscription API - Add comprehensive example c07-zai.rs - Update adapter kind detection to handle "zai" namespace - Remove dual-endpoint complexity from user-facing API Co-authored-by: Rui Andrada <rui.andrada@imaginedone.com.br>
Resolved conflicts in Z.AI adapter implementation: - Consolidated duplicate Zai/ZAi adapters into single Zai adapter - Updated model routing logic for Z.AI models - Removed obsolete zhipu adapter references - Added cerebras module to adapters - Preserved dual endpoint support for Z.AI coding plans 🤖 Generated with [terraphim.ai](https://terraphim.ai) Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed import paths for adapters after module reorganization - Removed remaining duplicate ZAi adapter references - Added missing openrouter module export - Ensured consistent adapter import structure 🤖 Generated with [terraphim.ai](https://terraphim.ai) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
PR #3 completed successfully! All changes have been merged to main:
Additionally, AWS Bedrock adapter integration has been squash-merged to main with:
✅ All objectives achieved |
AlexMikhalev
added a commit
that referenced
this pull request
Jan 12, 2026
Add comprehensive documentation from session fixing PR #3 and merging Bedrock integration: HANDOVER.md: - Complete progress summary (PR #3 fixed, Bedrock integrated) - Technical context (commits, files changed, discoveries) - Next steps and verification commands - All 4 commits documented with details lessons-learned.md: - 6 technical discoveries (Debug format, routing, let-chains, etc.) - Debugging approaches that worked - 5 pitfalls to avoid with solutions - 5 best practices discovered - Quick reference for commands and file locations Generated after successful completion of: - Fixed clippy warnings in test files and Bedrock adapter - Fixed ZAI model routing test expectations - Squash-merged AWS Bedrock adapter integration - All CI checks passing, main branch stable Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Testing
✅ Compilation successful
✅ Z.AI API integration verified with live tests
✅ Code quality checks passed (clippy, fmt)
🤖 Generated with terraphim.ai