Skip to content

fix(mongodb): Use wait strategy instead of deprecated wait_for_logs #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmorch wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −8
Open

fix(mongodb): Use wait strategy instead of deprecated wait_for_logs #943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions modules/mongodb/testcontainers/mongodb/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

from testcontainers.core.generic import DbContainer
from testcontainers.core.utils import raise_for_deprecated_parameter
from testcontainers.core.waiting_utils import wait_for_logs
from testcontainers.core.wait_strategies import LogMessageWaitStrategy


class MongoDbContainer(DbContainer):
Expand Down Expand Up @@ -57,7 +57,13 @@ def __init__(
**kwargs,
) -> None:
raise_for_deprecated_parameter(kwargs, "port_to_expose", "port")
super().__init__(image=image, **kwargs)
super().__init__(
image=image,
_wait_strategy=LogMessageWaitStrategy(
re.compile(r"waiting for connections", re.IGNORECASE)
),
**kwargs,
)
self.username = username if username else os.environ.get("MONGO_INITDB_ROOT_USERNAME", "test")
self.password = password if password else os.environ.get("MONGO_INITDB_ROOT_PASSWORD", "test")
self.dbname = dbname if dbname else os.environ.get("MONGO_DB", "test")
Expand All @@ -78,12 +84,8 @@ def get_connection_url(self) -> str:
)

def _connect(self) -> None:
regex = re.compile(r"waiting for connections", re.MULTILINE | re.IGNORECASE)

def predicate(text: str) -> bool:
return regex.search(text) is not None

wait_for_logs(self, predicate)
# LogMessageWaitStrategy handles waiting for container readiness
pass

def get_connection_client(self) -> MongoClient:
return MongoClient(self.get_connection_url())