Open
Conversation
Owner
|
Hi Dan, thanks for the pull request. I'm a bit concerned, for a couple of reasons. First, this assumes that a user of the gem is going to be using Rails, and that's not necessarily the case, although you did remind me that I have an implicit dependency on ActiveSupport that I really need to make explicit. Second, it assumes that a user always wants to output to STDERR, and always want to do so in development mode. I'd much prefer making this a simple configuration option, something to the effect of: This way, we could just check for that key on the config hash, and not swallow any and every error that might come our way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going through the certification process with Russ, he requested a SOAP Trace. I've added a line to the docusignDriver.rb APIServiceSoap class which will output this trace to STDERR automatically when the rails app is run in the development environment. This will work for modern (tested 2.3.2 and up) versions of rails, but may not in older versions, so I put a rescue nil at the end of the line.