fix "Can't find internal action" for quote macros when quote replacing is active#4358
Merged
sunderme merged 1 commit intotexstudio-org:masterfrom Mar 8, 2026
Merged
Conversation
Member
|
no need for the second extension |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open Config dialog. In Editor options choose a method for
Replace Double Quotes. This will add internal macrosTXS_AUTO_REPLACE_QUOTE_OPENandTXS_AUTO_REPLACE_QUOTE_CLOSEto the userMacros list but only after actions have been setup for the (usual) user macros (c.f.
ConfigManager::updateUserMacroMenu).When Config dialog is closed with ok
ConfigManager::updateUserMacroShortcutsis executed. It selects each macro from the userMacros list and calls getManagedAction. Obviously this needs to fail for the internal macros mentioned above. Debug messagesCan't find internal actionare written for both macros.Also abbreviations come in mind. But debugging
LatexCompleter::updateAbbreviationsshows that macros are skipped whenmacro.abbrev.isEmpty() || macro.snippet().isEmpty()is true. Indeed, this holds for the internal macros because they don't use abbreviations. Since this may not be obvious, it might be reasonable extending the condition in a similar way as this PR does for the shortcuts. Let me know when I should do so.