Skip to content

Comments

Thai nguyen#1

Open
thaiq8nguyen wants to merge 3 commits intomasterfrom
thai-nguyen
Open

Thai nguyen#1
thaiq8nguyen wants to merge 3 commits intomasterfrom
thai-nguyen

Conversation

@thaiq8nguyen
Copy link
Owner

No description provided.

Copy link

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small changes

Comment on lines +40 to +42
const newColorList = colors.filter(color => {
return color.id !== deletedColorID;
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const newColorList = colors.filter(color => {
return color.id !== deletedColorID;
});
const newColorList = colors.filter(color => color.id !== deletedColorID);

Comment on lines +20 to +24
if (token) {
return true;
} else {
return false;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (token) {
return true;
} else {
return false;
}
return !!token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants