fix(api): use 6.2+ scheduled action API#13
Open
baby-gnu wants to merge 1 commit intothe-berta-project:masterfrom
Open
fix(api): use 6.2+ scheduled action API#13baby-gnu wants to merge 1 commit intothe-berta-project:masterfrom
baby-gnu wants to merge 1 commit intothe-berta-project:masterfrom
Conversation
* berta.gemspec: require opennebula library between 6.2 and 6.4. * lib/berta/entities/expiration.rb (Berta::Entities::Expiration.from_xml): expiration can be relative to the start time of the virtual machine, always make it a full timestamp. * lib/berta/entities/expiration.rb (Berta::Entities::Expiration#template): create punctual schedule action with required `END_TYPE`. * lib/berta/virtual_machine_handler.rb (Berta::VirtualMachineHandler): instead of updating the VM template, use the `sched_action_add` and `sched_action_delete` API directly. Lookup scheduled action under `TEMPLATE` instead of old `USER_TEMPLATE`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
berta.gemspec: require opennebula library between 6.2 and 6.4.
lib/berta/entities/expiration.rb (Berta::Entities::Expiration.from_xml):
expiration can be relative to the start time of the virtual machine,
always make it a full timestamp.
lib/berta/entities/expiration.rb (Berta::Entities::Expiration#template):
create punctual schedule action with required
END_TYPE.lib/berta/virtual_machine_handler.rb (Berta::VirtualMachineHandler):
instead of updating the VM template, use the
sched_action_addandsched_action_deleteAPI directly.Lookup scheduled action under
TEMPLATEinstead of oldUSER_TEMPLATE.Fixes: #12