Add implementation plan for cloud secret manager support (Issue #23)#27
Closed
Add implementation plan for cloud secret manager support (Issue #23)#27
Conversation
Covers architecture, file changes, testing strategy, and phasing for
adding {{#gcp:...}}, {{#aws:...}}, {{#azure:...}} secret references
to the expression/interpolation engine.
https://claude.ai/code/session_01K9aguf3SXNiy25vwT3wBkA
Implements infrastructure for resolving cloud secrets in {{}} template
expressions (Issue #23). Adds GCP Secret Manager support with #gcp:
prefix and optional #fragment JSON field extraction.
New packages:
- secretresolver: SecretResolver interface, ParseSecretRef, ExtractFragment
- secretresolver/gcpsecret: GCP Secret Manager implementation with caching
Expression package changes:
- Add #gcp:, #aws:, #azure: prefix recognition to resolveVar() dispatch
- Thread context.Context through interpolation for network calls
- Add SecretReferenceError type with provider/ref/fragment fields
- Add WithSecretResolver() builder on UnifiedEnv
- Mask secret values as "***" in variable tracking
Wiring:
- Add SecretResolver field to FlowNodeRequest
- Pass resolver through FlowLocalRunner -> FlowNodeRequest -> nodes
- Wire into request node (sync + async) and AI node
- Use variadic parameter in PrepareHTTPRequestWithTracking for
backward-compatible secret resolver injection
Tests:
- Unit tests for fragment extraction, reference parsing, multi-resolver
- Expression tests with mock SecretResolver (GCP, AWS, Azure prefixes)
- Integration test skeleton behind gcp_integration build tag
Note: go.mod adds cloud.google.com/go/secretmanager dependency.
Run `go mod tidy` with network access to update go.sum.
https://claude.ai/code/session_01K9aguf3SXNiy25vwT3wBkA
Contributor
Author
|
Closing in favor of new PR with renamed branch (feat/ prefix) and squashed commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers architecture, file changes, testing strategy, and phasing for
adding {{#gcp:...}}, {{#aws:...}}, {{#azure:...}} secret references
to the expression/interpolation engine.
https://claude.ai/code/session_01K9aguf3SXNiy25vwT3wBkA