mobile toggle position plus other minor edits#5
Open
Nix7amcm wants to merge 1 commit intothecodercoder:mainfrom
Open
mobile toggle position plus other minor edits#5Nix7amcm wants to merge 1 commit intothecodercoder:mainfrom
Nix7amcm wants to merge 1 commit intothecodercoder:mainfrom
Conversation
-toggle position for mobile with line -header media query flex-direction column -minor change to breakpoints-down small to cover px 639 jump -toggle label color -toggle focus state and height slight adjustment -toggle focus color variables added -toggle button position slight adjustment -slight margin-left to centre Followers -h1 h2 margin-bottom increase -h2 color
Author
|
Thanks so much for your fab Youtube course on this! You're so easy to follow and explain everything so well. I really learned a lot! At the end, I decided to try fix the toggle position for mobile size, and came across a few other minor edits along the way. So thought I'd share in case you wanted to add them! Can't wait to check out more of your vids 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-toggle positioning for mobile with border-top line
-- header media query flex-direction column
-- minor change to breakpoints-down small to cover missing 639px
-toggle focus edited
-- slight height adjustment
-- toggle focus color variables added
-toggle label color
-toggle button position minor adjustment
-slight margin-left to centre Followers more
-h1 h2 margin-bottom increased
-h2 color