fix: Clean up login event handling#187
Open
bobbyonmagic wants to merge 1 commit intothedevdojo:mainfrom
Open
Conversation
- Fire Attempting event with correct rememberMe value - Add missing Failed event for edge case when user not found - Replace Auth::attempt() with Auth::login() since credentials already validated - Prevents duplicate Attempting/Failed events from Auth::attempt() internal firing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inconsistent login event firing.
Changes
Attemptingevent now passes correctrememberMevalue (was hardcoded tofalse)Failedevent for edge case when user not found after validationAuth::attempt()withAuth::login()to prevent duplicate eventsWhy
Previously, events were fired both manually AND internally by
Auth::attempt(), causing duplicateAttemptingandFailedevents. Since credentials are already validated withAuth::validate(), we now useAuth::login()and fireLoginevent manually.