Skip to content

Conversation

@kbberker
Copy link
Collaborator

WOOP

Seems to be working, although haven't been able to test how it would work being offline in chrome.

Seen below is screenshot of localstorage in chrome.
Screenshot 2019-03-26 at 20 20 39

Probably not following pull request etiquette here...

@kbberker kbberker requested a review from jamesdoc March 26, 2019 20:21
@jamesdoc
Copy link
Member

This is looking very good. 👍

However … what is going to happen on Monday morning when the feed is updated and how might we solve that problem?

@kbberker
Copy link
Collaborator Author

Ah yes very good point.

My initial thinking is:

  • Also fetch latest sermons
  • Does localstorage contain the latest sermon
  • if yes - do nothing
  • if no - update localstorage

But will need to see what happens if the fetch fails (because someone is offline).

@jamesdoc
Copy link
Member

Nice thought.

A step before that: Wait until initial load completed - don't slow everything down for this. Just assume everything is fine on first load (hasCompletedLoad might help here).

A step after that: Update the state if local storage changed.

@jamesdoc jamesdoc marked this pull request as draft January 28, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants