Added new parse to dictionary nullable#17
Closed
Paulohos wants to merge 2 commits intothejohnlima:mainfrom
Closed
Conversation
|
thejohnlima
requested changes
Jun 17, 2025
| } | ||
|
|
||
| /// Returns an optional `LMJSONOptional` if the serialization is successful; otherwise, returns `nil`. | ||
| public func dictionaryNullable() -> LMJSONOptional? { |
| } | ||
|
|
||
| /// Returns an optional `LMJSONOptional` if the serialization is successful; otherwise, returns `nil`. | ||
| public func dictionaryNullable() -> LMJSONOptional? { |
Owner
There was a problem hiding this comment.
Would be better to declare this function after the dictionary() one:
| XCTAssertEqual(movies.last?.title, "Iron Man") | ||
| } | ||
|
|
||
| func testParseNullable() { |
Owner
There was a problem hiding this comment.
This project uses 2 for tab and indent, so it needs to adjust the code indentation accordingly.
|
|
||
| @testable import LMStorage | ||
|
|
||
| struct ContentId: LMCodable { |
Owner
There was a problem hiding this comment.
Would be better to simplify this model this way:
struct Media: LMCodable {
var id: String?
var source: String?
}|
|
||
| func testParseNullable() { | ||
| let contet = ContentId(id: "Movie-ID", seriesTmdb: nil, source: "Amazon Prime") | ||
| let dict = contet.dictionaryNullable() |
Owner
Owner
There was a problem hiding this comment.
Please let me know if it works for you
Owner
There was a problem hiding this comment.
If it works, we can still keep the PR to add the unit test to cover this scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.