Support Python3 & Python2 #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now chemtools/conceptual/test tests pass with both Python 2 and 3.
Now chemtools/outputs/test tests pass with both Python 2 and 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Python3 (i.e., using iodata, grid, and gbasis) in addition to Python2 (i.e., using horton). So, chemtools can be imported/used with both Python 2 & 3 (some features would not be available with Python 3 yet, which results in an informative error). The tests can also be run with Python 2 & Python 3 (environments with proper dependencies installed) as well; some tests will be skipped depending on the Python version.
Checks
Type of Changes
Please remove the lines that don't represent the type of your PR.
✨ New Feature
🎨 Improve Format & Structure