This repository was archived by the owner on Feb 13, 2019. It is now read-only.
Limit <audio> tag creation, or don't. #46
Open
phiggins42 wants to merge 2 commits intotheonion:masterfrom
Open
Limit <audio> tag creation, or don't. #46phiggins42 wants to merge 2 commits intotheonion:masterfrom
phiggins42 wants to merge 2 commits intotheonion:masterfrom
Conversation
added 2 commits
June 23, 2013 09:02
The code to search existing audio tags for a completed fart to reuse is flawed. It doesn't actually iterate. Well, it does iterate something, but not like the author expected. Backwards compatible patch, just remove the lookup.
Because the check for existing elements was faulty, endless audio tags are created over time. In SPA or such this could be a lot of elements. Got Chrome to AW SNAP at me after 15 minutes of calling playAudio on an interval. This fixes the check for existing elements. You can call playaudio as often as you like, only ever creating just enough elements to play N simultaneous sounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits: the first simply removes a redundant bit of code. The second replaces that redundant bit with a working bit. If latter behavior is not actually desired (as the former is actually the current implementation), only take the one.