-
Notifications
You must be signed in to change notification settings - Fork 86
Adding togglable ANSI colored logs #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bartoszkwiat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
|
Maybe in the future I will add full customization of the colors...we will see. |
|
Since this repository seems unmaintained, I decided to grab all pull requests in this repo which seemed polished enough and I added my own changes. I plan to maintain my fork and I'm sharing the link here just in case it would be useful to someone else. The library is already published in the PlatformIO registry. Check the release page for full details. |
|
@thijse should we sunset this repo in favor of the maintained fork from @vzahradnik ? Or add @vzahradnik as a contributor here and recombine them? |
|
Thanks for mentioning me. I created the fork because I needed a working library with the features that were piling up here in pull requests. I have no problem abandoning my work if this repository gets revived. I always prefer a maintained library upstream than forks downstream. |
|
I feel like we should get you in here, merge all.PRs, do a release and publish it to platformIO as well..would you be happy to take that on? |
|
Sure. Just let me know how would you like to proceed. In my fork I not only included all outstanding PRs that felt ready but I also did a slight refactoring and set up CI/CD. Commit history is our trail. |
|
@thijse, this is your repo - thoughts? |

This is a fork of @xHeler 's idea of implementing ANSI colours to distinguish different log types.
I have added the possibility to enable/disable (default disabled) this functionality either from the constructor:
or by calling the specific method:
I also improved the readability of the code by refactoring the part that deals with printing ANSI codes