Footnotes fix, option 1 #115
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change arises from a confusing issue where Ben was unable to make use of the core WP footnote functionality in prepping a site for a client pitch. As it turns out, the footnote item in the rich text editor is only available if the core footnotes block is permitted. Since this "check for block permission to allow feature" method seems to have been part of WP for several releases now, it seems possible that it will be linked to other things in future.
This is one way to prevent the issue from cropping up again--rather than specifying a set list of blocks to allow in the theme, retrieve a list of all of them from the registry and pick out the core blocks. This might be too permissive, though. Gabe submitted #114 as an alternative.