main.cpp: fix incorrect Windows detection macros.#17
Merged
thliebig merged 1 commit intothliebig:masterfrom Dec 21, 2025
Merged
main.cpp: fix incorrect Windows detection macros.#17thliebig merged 1 commit intothliebig:masterfrom
thliebig merged 1 commit intothliebig:masterfrom
Conversation
To detect Windows, the _WIN32 and _WIN64 C macro contain one underscore, not two underscores. The keyword "not" is also an ISO 646 alias to "!", so its use is discouraged. Signed-off-by: Yifeng Li <tomli@tomli.me>
13 tasks
Contributor
Author
|
Merge ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To detect Windows, the
_WIN32and_WIN64C macro contain one underscore, not two underscores. The keywordnotis also an ISO 646 alias to!, so its use is discouraged.