fix: 2nd parameter on WebGLRenderLists.get should be a number#126
Merged
joshuaellis merged 1 commit intothree-types:masterfrom Sep 18, 2021
Merged
fix: 2nd parameter on WebGLRenderLists.get should be a number#126joshuaellis merged 1 commit intothree-types:masterfrom
joshuaellis merged 1 commit intothree-types:masterfrom
Conversation
The second parameter of WebGLRenderLists.get() should be a number indicating the render call depth. Three.js source line here: https://github.com/mrdoob/three.js/blob/68b5f4f0cc279b6b7c61205aeda72b995a3642f5/src/renderers/webgl/WebGLRenderLists.js#L205
joshuaellis
approved these changes
Sep 18, 2021
MykhailoStrelnykov
pushed a commit
to Chronos-Samples/three-ts-types
that referenced
this pull request
Dec 22, 2025
…types#126) The second parameter of WebGLRenderLists.get() should be a number indicating the render call depth. Three.js source line here: https://github.com/mrdoob/three.js/blob/68b5f4f0cc279b6b7c61205aeda72b995a3642f5/src/renderers/webgl/WebGLRenderLists.js#L205 Co-authored-by: Tom <t.schwarz@axial3d.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second parameter of WebGLRenderLists.get() should be a number indicating the render call depth.
Three.js source line here:
https://github.com/mrdoob/three.js/blob/68b5f4f0cc279b6b7c61205aeda72b995a3642f5/src/renderers/webgl/WebGLRenderLists.js#L205
Why
Fixing a blocking bug relating to WebGLRenderLists. The param was updated in three here: mrdoob/three.js#21254
What
Modified a parameter name and type con the WebGLRenderLists.get() function. It was set as a Camera but it needs to be a number for the current version of three.
Checklist