Use backend-only category data for resource filters#35
Closed
thughari wants to merge 3 commits intofeat/career-resourcefrom
Closed
Use backend-only category data for resource filters#35thughari wants to merge 3 commits intofeat/career-resourcefrom
thughari wants to merge 3 commits intofeat/career-resourcefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
GET /api/resources/categoriesimplemented inCareerResourceControllerand backed byCareerResourceService#getAllCategories()to return distinct, sorted persisted categories.findDistinctCategories()JPQL query inCareerResourceRepositoryand exposed a service method to fetch categories from the database.ResourceServicewithgetResourceCategories()and a small client-side cache that is cleared byinvalidateCache(); also kept the pagedgetResources()shape and added create/upload/update/delete flows to invalidate caches.ResourcesComponentto remove hardcoded category defaults, load backend category options vialoadCategoryOptions()on init and after add/edit/delete, and bind the UI filter to backend-provided categories; updatedresources.component.spec.tsmocks accordingly.Testing
npm --prefix frontend run test -- --watch=false --browsers=ChromeHeadless, which reached Karma but failed to launchChromeHeadlessbecause the binary is not available in this environment (test could not complete).npm --prefix frontend run build, which failed in this environment due to Google Fonts inlining returning HTTP 403 (external network/font limitation).mvn -q test, which failed here because Maven could not resolve the Spring Boot parent POM from Maven Central (HTTP 403 in this environment).Codex Task