Better error messages during calendar connection #1464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We are currently capturing some errors during calendar connection:
However, we were only showing the title "We couldn't connect to your calendar" and not the description. Now we are showing that in the notice bar!
Also, we are now separating a little bit the
NotFoundErrorand an invalid XML returned as their own error messages.Screenshots of some examples:
Known issues / Things to improve
NoticeBarcomponent could use some style changes for title / description as there's not a lot of hierarchy in typography.Benefits
Applicable Issues
Fixes #1457