Fix schema mismatch: Use "CalendarItemFormats" (plural) in calendar-items.json#57
Merged
kewisch merged 1 commit intothunderbird:mainfrom Apr 13, 2025
Merged
Fix schema mismatch: Use "CalendarItemFormats" (plural) in calendar-items.json#57kewisch merged 1 commit intothunderbird:mainfrom
kewisch merged 1 commit intothunderbird:mainfrom
Conversation
…alendarItemFormat" (singular).
kewisch
approved these changes
Mar 11, 2025
rsjtdrjgfuzkfg
pushed a commit
to rsjtdrjgfuzkfg/thunderbird-birthdaycalendar
that referenced
this pull request
Mar 16, 2025
This commit updates the calendar API experiment to e730a7b2a483f5cf8f0e0d9dbc7bc6f9394501f5 with an additional fix from thunderbird/webext-experiments#57 As a consequence, unsupported builds now work correctly on Thunderbird 136.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a schema inconsistency in web-experiments in
calendar-items.jsonwhere the code expectsCalendarItemFormat(singular), but the schema defines it asCalendarItemFormats(plural).Issue
CalendarItemFormat, leading to failures. For example, if one uses the following valid update call:despite all parameters being correct, this results in a
DOMException/InvalidStateError.CalendarItemFormats(plural), which aligns with the definition of the enumCalendarItemFormats.Fix
Updated references in
calendar-items.jsonto useCalendarItemFormatsconsistently.