Fix intendation/scope for block responsible of jku-var exchange.#105
Open
disasmwinnie wants to merge 1 commit intoticarpi:masterfrom
Open
Fix intendation/scope for block responsible of jku-var exchange.#105disasmwinnie wants to merge 1 commit intoticarpi:masterfrom
disasmwinnie wants to merge 1 commit intoticarpi:masterfrom
Conversation
I belive this addresses the problem described in issue ticarpi#90. To reproduce the undefined var in line it I had to run in the scan mode "-M at" and you need a JWT that defines "jku" field. In that case the try block before succeds. That lead to the "jku" variable never to be defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I belive this addresses the problem described in issue #90. To reproduce the undefined var in line it I had to run in the scan mode "-M at" and you need a JWT that defines "jku" field. In that case the try block before succeds. That lead to the "jku" variable never to be defined.