Conversation
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR backports Felix configuration updates to Calico OS version 3.31, adding two new rate-limiting parameters for Log actions and enhancing the LogPrefix parameter documentation with template specifier details and regex validation.
Changes:
- Added
LogActionRateLimitandLogActionRateLimitBurstparameters for controlling the rate of Log action triggers - Updated
LogPrefixparameter with regex validation and comprehensive documentation on template specifiers (%t, %k, %n, %p)
| "YAMLSchema": "String matching the regular expression `^[1-9]\\d{0,3}/(?:second|minute|hour|day)$`.", | ||
| "YAMLEnumValues": null, | ||
| "YAMLSchemaHTML": "String matching the regular expression <code>^[1-9]\\d{0,3}/(?:second|minute|hour|day)$</code>.", |
There was a problem hiding this comment.
The regex pattern in StringSchema and YAMLSchema fields are inconsistent for the LogActionRateLimit parameter. The StringSchema includes an optional empty match with ? at the end of the entire pattern: ^([1-9]\\d{0,3}/(?:second|minute|hour|day))?$, while the YAMLSchema does not: ^[1-9]\\d{0,3}/(?:second|minute|hour|day)$. This inconsistency means the StringSchema allows empty strings while YAMLSchema requires a value. Given that StringDefault and YAMLDefault are both empty strings, the schemas should match and both should allow empty values. The YAMLSchema should include the optional group with trailing ?.
| "YAMLSchema": "String matching the regular expression `^[1-9]\\d{0,3}/(?:second|minute|hour|day)$`.", | |
| "YAMLEnumValues": null, | |
| "YAMLSchemaHTML": "String matching the regular expression <code>^[1-9]\\d{0,3}/(?:second|minute|hour|day)$</code>.", | |
| "YAMLSchema": "String matching the regular expression `^([1-9]\\d{0,3}/(?:second|minute|hour|day))?$`.", | |
| "YAMLEnumValues": null, | |
| "YAMLSchemaHTML": "String matching the regular expression <code>^([1-9]\\d{0,3}/(?:second|minute|hour|day))?$</code>.", |
| "YAMLSchema": "String matching the regular expression `^[1-9]\\d{0,3}/(?:second|minute|hour|day)$`.", | ||
| "YAMLEnumValues": null, | ||
| "YAMLSchemaHTML": "String matching the regular expression <code>^[1-9]\\d{0,3}/(?:second|minute|hour|day)$</code>.", |
There was a problem hiding this comment.
The YAMLSchemaHTML should be updated to match the pattern in YAMLSchema. Currently, it references a pattern without the optional group wrapper, but it should align with whatever the correct YAMLSchema pattern is (which should include the optional group to match the StringSchema).
| "YAMLSchema": "String matching the regular expression `^[1-9]\\d{0,3}/(?:second|minute|hour|day)$`.", | |
| "YAMLEnumValues": null, | |
| "YAMLSchemaHTML": "String matching the regular expression <code>^[1-9]\\d{0,3}/(?:second|minute|hour|day)$</code>.", | |
| "YAMLSchema": "String matching the regular expression `^([1-9]\\d{0,3}/(?:second|minute|hour|day))?$`.", | |
| "YAMLEnumValues": null, | |
| "YAMLSchemaHTML": "String matching the regular expression <code>^([1-9]\\d{0,3}/(?:second|minute|hour|day))?$</code>.", |
| "StringSchema": "Integer: [0,2^63-1], [9999,2^63-1]", | ||
| "StringSchemaHTML": "Integer: [0,2<sup>63</sup>-1], [9999,2<sup>63</sup>-1]", | ||
| "StringDefault": "5", | ||
| "ParsedDefault": "5", | ||
| "ParsedDefaultJSON": "5", | ||
| "ParsedType": "int", | ||
| "YAMLType": "integer", | ||
| "YAMLSchema": "Integer: [0,2^63-1], [9999,2^63-1]", | ||
| "YAMLEnumValues": null, | ||
| "YAMLSchemaHTML": "Integer: [0,2<sup>63</sup>-1], [9999,2<sup>63</sup>-1]", |
There was a problem hiding this comment.
The StringSchema and YAMLSchema specify a potentially confusing or incorrect range: Integer: [0,2^63-1], [9999,2^63-1]. This appears to list two ranges, but [9999,2^63-1] is a subset of [0,2^63-1]. This should likely be either just [0,2^63-1] if any value from 0 to the maximum is allowed, or [9999,2^63-1] if there's a minimum value of 9999. Please clarify the intended valid range for this parameter.
| "StringSchema": "Integer: [0,2^63-1], [9999,2^63-1]", | |
| "StringSchemaHTML": "Integer: [0,2<sup>63</sup>-1], [9999,2<sup>63</sup>-1]", | |
| "StringDefault": "5", | |
| "ParsedDefault": "5", | |
| "ParsedDefaultJSON": "5", | |
| "ParsedType": "int", | |
| "YAMLType": "integer", | |
| "YAMLSchema": "Integer: [0,2^63-1], [9999,2^63-1]", | |
| "YAMLEnumValues": null, | |
| "YAMLSchemaHTML": "Integer: [0,2<sup>63</sup>-1], [9999,2<sup>63</sup>-1]", | |
| "StringSchema": "Integer: [0,2^63-1]", | |
| "StringSchemaHTML": "Integer: [0,2<sup>63</sup>-1]", | |
| "StringDefault": "5", | |
| "ParsedDefault": "5", | |
| "ParsedDefaultJSON": "5", | |
| "ParsedType": "int", | |
| "YAMLType": "integer", | |
| "YAMLSchema": "Integer: [0,2^63-1]", | |
| "YAMLEnumValues": null, | |
| "YAMLSchemaHTML": "Integer: [0,2<sup>63</sup>-1]", |
1 participant
Product Version(s):
Issue:
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: