Make manager proceed with deploying even with voltron route config error#3772
Open
tmjd wants to merge 2 commits intotigera:masterfrom
Open
Make manager proceed with deploying even with voltron route config error#3772tmjd wants to merge 2 commits intotigera:masterfrom
tmjd wants to merge 2 commits intotigera:masterfrom
Conversation
Deploy the majority of manager even if there is a voltron route config error for the cases where part of the config depends on something manager will create.
Brian-McM
reviewed
Feb 12, 2025
| return reconcile.Result{}, err | ||
| routeConfig, routeConfigErr := getVoltronRouteConfig(ctx, r.client, helper.InstallNamespace()) | ||
| if routeConfigErr != nil { | ||
| log.Error(routeConfigErr, "error with voltron route config, continuing") |
Contributor
There was a problem hiding this comment.
Could you also say "route configuration will not be added to voltron"?
Brian-McM
approved these changes
Feb 12, 2025
tmjd
force-pushed
the
propose-route-toleration
branch
from
9478217 to
f88ac58
Compare
Brian-McM
reviewed
Apr 8, 2025
| r.licenseAPIReady.MarkAsReady() | ||
| r.tierWatchReady.MarkAsReady() | ||
| }) | ||
| It("single-tenant", func() { |
Contributor
There was a problem hiding this comment.
Nit, the description of the test with it should flow with "It ", so this reads as "It single-tenant".
So this should probably be something like It("creates the manager deployment and degrades the tigera status for a single tenant"). Could also be wrapped in another Context or When saying if it's single tenant or multi tenant.
Brian-McM
approved these changes
Apr 8, 2025
|
This PR is stale because it has been open for 60 days with no activity. |
Member
Author
|
Thanks github-actions bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy the majority of manager even if there is a voltron route config error for the cases where part of the config depends on something manager will create.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.