Skip to content

tests: stabilize TestUpdateMemberWhenRecovery retry path #10285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okJiang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: stabilize TestUpdateMemberWhenRecovery retry path #10285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tests/integrations/mcs/keyspace/tso_keyspace_group_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,9 +737,19 @@ func (suite *keyspaceGroupTestSuite) TestUpdateMemberWhenRecovery() {
nodes[newNode.GetAddr()] = newNode
tests.WaitForPrimaryServing(re, map[string]bs.Server{newNode.GetAddr(): newNode})

// Step 7: Verify GetTS succeeds after node restart
// Step 7: Verify GetTS succeeds after node restart.
// The restarted node may transiently serve stale keyspace-group metadata
// before watch sync catches up, so tolerate one transient GetTS error and
// assert eventual recovery instead of requiring immediate success.
result := <-resultCh
re.NoError(result.err, "GetTS should succeed after TSO node restart")
if result.err != nil {
testutil.Eventually(re, func() bool {
retryCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
_, _, err := client.GetTS(retryCtx)
return err == nil
}, testutil.WithWaitFor(60*time.Second), testutil.WithTickInterval(500*time.Millisecond))
}

// KEY VERIFICATION: If code incorrectly tried to fallback to legacy path,
// assertNotReachLegacyPath failpoint would have panicked already
Expand Down
Loading