Skip to content

chore(dashboard): update TiDB Dashboard to 20260305120502-70e5bb19e006 [master]#10324

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
yibin87:chore/update-tidb-dashboard-20260310
Mar 10, 2026
Merged

chore(dashboard): update TiDB Dashboard to 20260305120502-70e5bb19e006 [master]#10324
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
yibin87:chore/update-tidb-dashboard-20260310

Conversation

@yibin87
Copy link
Contributor

@yibin87 yibin87 commented Mar 10, 2026

What problem does this PR solve?

Issue Number: Close #10323

What is changed and how does it work?

  • Bump github.com/pingcap/tidb-dashboard to v0.0.0-20260305120502-70e5bb19e006 (tidb-dashboard master @ 70e5bb19e006).
  • Keep the version consistent in the root module as well as the tests/integrations and tools sub-modules.

Check List

Tests

  • Manual test
    • make pd-server

Code changes

  • No configuration change
  • No HTTP APIs changed
  • No persistent data change

Side effects

  • None

Related changes

  • None

Release note

None.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated tidb-dashboard dependency to the latest version across multiple modules.

…6 [master]

Signed-off-by: yibin87 <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 10, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2026

Hi @yibin87. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3f3af1ed-78de-4e36-a0fc-149adc19da5a

📥 Commits

Reviewing files that changed from the base of the PR and between 58252c5 and 7867e07.

⛔ Files ignored due to path filters (3)
  • go.sum is excluded by !**/*.sum
  • tests/integrations/go.sum is excluded by !**/*.sum
  • tools/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • go.mod
  • tests/integrations/go.mod
  • tools/go.mod

📝 Walkthrough

Walkthrough

The tidb-dashboard Go module dependency is updated to the latest upstream commit across three go.mod files (root, tests/integrations, and tools) to keep PD synchronized with TiDB Dashboard and ensure consistent version resolution.

Changes

Cohort / File(s) Summary
Dependency Version Updates
go.mod, tests/integrations/go.mod, tools/go.mod
Bumped github.com/pingcap/tidb-dashboard from v0.0.0-20260112071732-805c56a830e0 to v0.0.0-20260305120502-70e5bb19e006 across all go.mod files to align with latest upstream commit.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A carrot for each version we chase,
Dependencies bumped into place,
Dashboard updated, shiny and new,
PD and TiDB, now in sync—it's true!
Master commits make our builds bloom,
No conflicts left in the room. 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the TiDB Dashboard dependency to a specific version.
Description check ✅ Passed The PR description covers all required sections: problem statement with issue number, changes made, testing approach, code changes checklist, and release notes.
Linked Issues check ✅ Passed All coding requirements from issue #10323 are met: dependency updated in root go.mod, tests/integrations, and tools sub-modules; version consistency maintained; manual verification via make pd-server completed.
Out of Scope Changes check ✅ Passed All changes are in-scope: only three go.mod files updated with the same TiDB Dashboard version bump, directly addressing the linked issue requirement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 10, 2026

/run-check-issue-triage-complete

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.79%. Comparing base (c1f3166) to head (7867e07).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10324      +/-   ##
==========================================
+ Coverage   78.78%   78.79%   +0.01%     
==========================================
  Files         527      527              
  Lines       70916    70920       +4     
==========================================
+ Hits        55870    55884      +14     
+ Misses      11026    11015      -11     
- Partials     4020     4021       +1     
Flag Coverage Δ
unittests 78.79% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 10, 2026
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 10, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 10, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-10 06:31:11.740306802 +0000 UTC m=+331703.252364473: ☑️ agreed by JmPotato.
  • 2026-03-10 06:52:27.156588214 +0000 UTC m=+332978.668645875: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit a7dbbf8 into tikv:master Mar 10, 2026
33 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Mar 10, 2026
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #10325.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(dashboard): update tidb-dashboard dependency

4 participants