Open
Conversation
added 6 commits
February 15, 2024 18:54
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
nkg-
reviewed
Mar 12, 2024
added 2 commits
March 13, 2024 14:16
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Member
|
@tonyxuqqi What is the WAL recovery mode in tikv ? I guess that it should be kTolerateCorruptedTailRecords. |
Member
|
which format is tikv using. Seems like rocksdb wal has two formats : legacy and recycle. Recycle format has more debug information (log number) . https://github.com/facebook/rocksdb/wiki/Write-Ahead-Log-File-Format |
added 2 commits
March 14, 2024 14:23
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
nkg-
reviewed
Mar 19, 2024
| "Start writing to WAL: [%" PRIu64 " ]", | ||
| log_writer->get_log_number()); | ||
| } | ||
| if (log_writer->get_log_number() != logs_.back().number) { |
There was a problem hiding this comment.
@tonyxuqqi : At the beginning of the write, writer will reference the last WAL only. The race condition happens, while the write is ongoing. We should check this condition after the write.
nkg-
reviewed
Mar 19, 2024
| io_s = WriteToWAL(*merged_batch, log_writer, log_used, &log_size, | ||
| log_file_number_size); | ||
| log_file_number_size, 1); | ||
| if (to_be_cached_state) { |
There was a problem hiding this comment.
Can you also add a lot when the fsync happens in writeToWAL
rocksdb/db/db_impl/db_impl_write.cc
Line 1519 in 20225a4
added 8 commits
March 21, 2024 16:46
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
This reverts commit 844300e.
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
Signed-off-by: Qi Xu <tonyxuqqi@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To debug WAL corruption issues