support pre-generate bindings for aarch64#435
Merged
Connor1996 merged 13 commits intotikv:masterfrom Mar 6, 2020
Merged
Conversation
Signed-off-by: glorv <glorvs@163.com>
Member
|
Sorry, we have no plan to pre-generate bindings for aarch64. It's fine for generating it when building. |
Author
From v4.0, we need to support aarch64 platform, so it's make sense to use pre-generated bindings to make compilation easily. In cenos7 with aarch64 cpu, the raw bind-gen need newer version of clang (>6) which isn't provided in most case. So I think we should support this feature. |
Signed-off-by: glorv <glorvs@163.com>
…contain enough components for aarch64 Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Author
|
@yiwu-arbug PTAL |
yiwu-arbug
pushed a commit
that referenced
this pull request
Mar 20, 2020
* add pre generated binding for aarch64 Signed-off-by: glorv <glorvs@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #402 we already support pre-generate bindings for x64_64, this pr add support for aarch64
Signed-off-by: glorv glorvs@163.com