Skip to content

Fix data race in MemTable::GetBloomFilter() on ARM weak memory model#841

Closed
hhwyt wants to merge 1 commit intotikv:masterfrom
hhwyt:fix-bloomfilter-race
Closed

Fix data race in MemTable::GetBloomFilter() on ARM weak memory model#841
hhwyt wants to merge 1 commit intotikv:masterfrom
hhwyt:fix-bloomfilter-race

Conversation

@hhwyt
Copy link

@hhwyt hhwyt commented Nov 18, 2025 •
edited
Loading

Update to commit tikv/rocksdb#424.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2025
@hhwyt hhwyt force-pushed the fix-bloomfilter-race branch from a3d7185 to 8e9766b Compare November 18, 2025 06:32
@hhwyt hhwyt changed the title Fix data race in MemTable::GetBloomFilter() on ARM weak memory model Fix data race in MemTable::GetBloomFilter() on ARM weak memory model (#424) Nov 18, 2025
@hhwyt hhwyt changed the title Fix data race in MemTable::GetBloomFilter() on ARM weak memory model (#424) Fix data race in MemTable::GetBloomFilter() on ARM weak memory model Nov 18, 2025
@hhwyt hhwyt force-pushed the fix-bloomfilter-race branch from 8e9766b to 0ea6451 Compare November 18, 2025 06:36
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hbisheng
Once this PR has been reviewed and has the lgtm label, please assign nrc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-18 06:43:29.019300648 +0000 UTC m=+1375658.462330517: ☑️ agreed by hbisheng.

@hhwyt
Copy link
Author

hhwyt commented Nov 18, 2025

/retest

@hhwyt
Copy link
Author

hhwyt commented Nov 18, 2025

/test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

@hhwyt: No presubmit jobs available for tikv/rust-rocksdb@master

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hhwyt
Copy link
Author

hhwyt commented Nov 18, 2025

/run-test

@hhwyt
Copy link
Author

hhwyt commented Nov 18, 2025

closed because #839 will update this change to the master.

@hhwyt hhwyt closed this Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hbisheng hbisheng hbisheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hhwyt @hbisheng