Skip to content

Conversation

@chrisdrackett
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 16, 2026 03:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements improvements to List components, focusing on color prop propagation, layout adjustments, and code cleanup. The changes enable proper background color handling throughout the list component hierarchy and make layout adjustments to list spacing and headers.

Changes:

  • Added color prop support to List components (EmptyContent, ListGroup, ScrollView) for proper background color propagation
  • Adjusted list header height from 45 to 24 and introduced listSpacerHeight token
  • Removed outdated comments and refactored list wrapper logic for empty/loading states

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/config/tamagui.config.ts Updated list header height, refactored betweenLists token into a constant, and added listSpacerHeight
src/components/ScrollView/ScrollView.tsx Added color prop support and backgroundColor mapping
src/components/List/Wrapper/index.tsx Refactored empty/loading state rendering and added color prop propagation
src/components/List/Simple/stories.tsx Added new story with color prop, fixed typo in empty content text
src/components/List/Simple/index.tsx Wrapped list content in fragment with biome-ignore comment
src/components/List/Group/index.tsx Commented out isFullWidth prop, added console.log debug statement, added contentContainerStyle
src/components/List/EmptyContent.tsx Added color prop support and reformatted code
Comments suppressed due to low confidence (1)

src/components/ScrollView/ScrollView.tsx:34

  • The color prop is not applied when alwaysBounceVertical is false. The else branch should also pass backgroundColor={color} to maintain consistent behavior.
		return <TGScrollView {...props} />

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,19 +1,42 @@
import { ScrollView as TGScrollView } from "tamagui"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [tsc] <6133> reported by reviewdog 🐶
'TGScrollView' is declared but its value is never read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants