Added license file and copyright notice.#7
Added license file and copyright notice.#7dblock wants to merge 2 commits intotim-actions:masterfrom
Conversation
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
|
@dblock I run into this issue as well. For my code I switched to https://github.com/tisonkun/actions-dco which has explicit license file and also does not require additional GH action to be executed first to pull PR commits. It simplifies the flow configuration a bit IMO (see opensearch-project/opensearch-prometheus-exporter#210 for example). Also the new dco action implementation seem to provide more elaborated description of how to sign-off commits (which is very helpful). |
|
Thanks @lukas-vlcek. We've ended up phasing out our usage of this GitHub Action in favor of using an App https://probot.github.io/apps/dco/. Compliance wise its much easier for use to ensure apply to our whole organization. |
|
@peternied Still I can see GH action being used all over the place here: search opensearch-project org for "tim-actions/dco" |
Looks like they are just dups now with the org-wide tool, and should be bulk deleted. @peternied want to followup? |
|
@peternied Perhaps https://github.com/opensearch-project/opensearch-plugin-template-java should be treated with an exception because we can not assume the GitHub App is installed in the target repository/org. @Tim-Zhang I apology for hijacking this PR. 🙏 |
|
I've created a [slack thread] to continue the discussion. @.Tim-Zhang thanks for letting us borrow this PRs' comments section for this aside. |
We're using this action for DCO checks and noticed the license file is missing. The package.json specifies ICS license so I just added a license file from https://choosealicense.com/licenses/isc/.
Signed-off-by: dblock dblock@amazon.com