This repository was archived by the owner on Feb 4, 2022. It is now read-only.
Allow permissible behaviour to emit alternative status codes#73
Open
oligriffiths wants to merge 1 commit intotimble:masterfrom
Open
Allow permissible behaviour to emit alternative status codes#73oligriffiths wants to merge 1 commit intotimble:masterfrom
oligriffiths wants to merge 1 commit intotimble:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow permissible behaviour to emit alternative status codes
Why
Currently the permissible behavior only accepts
falseas a return value and tries to auto-determine if a method is permissible by checking if the user is authentic, and works out the appropriate exception to throw based on that. This PR allows for explicitly returning status code typesNote
Also, thinking it might be an idea to provide a way to easily blacklist actions from the controller for actions that are not accessible publically...
Test
This should function exactly as the current implementation but also allow for returning explicit status codes to dictate the specific exception type to be thrown.