Conversation
Configuration reading/handling
Create dummy interface and sample test
* Add MockDetector class and update protocol, interface to run mock test * Refactor DummyInterface round-handling, update docstrings, update example metadata * Remove toolset from MockDetector method signatures * Complete basic ONDProtocol functionality for testing, update sample config * Initialize detector with detector config instead of whole config
* Return populated feature/logit dicts from feature extraction method * Add world detection functionality * Add novelty classification functionality * Update protocol to use features_dict and logits_dict returned by feature extraction * Rename MockDetector to RandomNoveltyDetector * Update method signatures, docstrings, use smqtk * Pass round_id for constructing output filenames * Remove tinker import, update number of classes to match config * Fix type hint syntax * Mock save features * Update sample_config
#13) * Enable option to perform feature extraction only; update sample config * Continue if feature extraction only
* Call algorithm methods directly instead of using execute method with string argument * Restructure algorithm calls with toolset dict replacements * Update random novelty detector method signatures to match method calls in protocol
Add functionality for saving features and loading saved features
* Write out images/files to a temp directory and update returned path * Add errors.py
* Add novelty interface abstract class * Add random novelty detector adapter and update method signatures * Instantiate random novelty detector adapter instead of detector algorithm in OND protocol * Rename novelty_interface module to ond_adapter * Add initialize abstract method * Use pass instead of NotImplementedError * Add docstrings to abstract methods * Remove unnecessary smqtk imports * Move adapter class to separate module and update imports
waxlamp
reviewed
Jun 1, 2021
Contributor
waxlamp
left a comment
waxlamp
left a comment
There was a problem hiding this comment.
If this passes all tests and works as expected, then it's ok with me. Especially so if this PR simply consists of all the PRs already reviewed and merged to dev/ond.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to merge the OND development branch into
main.In its current state, it allows the GAE algorithm to be run (with red light world detection) on hardcoded test data.