add hardware matrix and some fixes for feather-nrf* and doc-gen README#385
Open
gen2thomas wants to merge 1 commit intotinygo-org:releasefrom
Open
add hardware matrix and some fixes for feather-nrf* and doc-gen README#385gen2thomas wants to merge 1 commit intotinygo-org:releasefrom
gen2thomas wants to merge 1 commit intotinygo-org:releasefrom
Conversation
111e5db to
df828c1
Compare
7d4ab95 to
3ed77fc
Compare
Closed
8461a5b to
e99f3ed
Compare
e99f3ed to
730c854
Compare
Member
|
This PR is really big and difficult to review all at once. Can you maybe split it up a bit? |
Member
|
There are a bunch of different changes that we may or may not want. Putting them all in one big PR makes it near-impossible to be selective about what goes in. I see you have a bunch of different stuff put together in this PR:
So basically what I'm asking is to put a bit more work in separating out the changes so that it becomes easier for reviewers to review the PR. |
Author
|
Hi @aykevl , thanks for (try to) reviewing it and your feedback. Of course, I can split up the parts, like you suggested. Maybe it is also a good idea to change the target branch to dev for the new PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have manually collected a new "Feature-Matrix" document, but most likely it would be possible to generate it.
This features are available for "doc-gen":
In addition:
Please let me know, what can be improved. E.g. one page each for MCU's which support PWM, BT, WiFi etc. would be more handy?
See #384 for some background