Implemented upload session APIs (multi-part uploads)#18
Open
Implemented upload session APIs (multi-part uploads)#18
Conversation
…nload() to content()
Author
Strange failure, maybe manually retry? |
Author
|
Ah yes, just remembered #2. So maybe the higher-level |
Owner
|
niceee, yea as much as possible I think the fancier stuff should be in go-dropy |
moved to go-dropy, see jpillora/go-dropy@5eee26d
Author
|
Striped out high-level |
Author
|
Adding new test with manually managed session upload... |
Author
|
Semaphore seems to be a bit buggy, https://semaphoreci.com/tj/go-dropbox/branches/pull-request-18/builds/4 also failed strangely |
Author
|
I'll sync with upstream again once #17 tests are fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
implemented auto-handled upload session method(see go-dropy)UploadSession()download()tocontent()("Content-upload endpoints" and "Content-download endpoints")decodeContent()helperPermanentlyDeleteendpoint path (not sure if it was incorrect on purpose?)Notes
files.go, the raw upload session methods (start/append/finish) could be moved tofiles_upload_session.goand then would becomeFiles.UploadSession.Start(),.Append(),.Finish()- though we'd have to renameUploadSession()to something else.PerformRetries boolso if any chunk failed, it would be retransmitted. This would require aChunkSizebuffer though to hold data in case of failure and maybe the Dropbox API doesn't fail that often so it might not be worth it...