Updated MongoDB Driver and FSharp Runtime#9
Updated MongoDB Driver and FSharp Runtime#9nukedbit wants to merge 11 commits intotkellogg:masterfrom nukedbit:master
Conversation
|
Hi Sebastian, I apologize for taking so long to get around to this PR. I'm not ready to merge this quite yet as there's a few outstanding issues I'd like to see resolved first. I'm not particularly happy that one of the changes wipes out my name as owner. If you really intend to commit time to this project, I'm open to discussing what we can do, but I assure you that nothing of the sort will happen in this PR. As for the other changes, I've just been skimming the code so I haven't been able to thoroughly read through the changes like I should. Still, there seems to be some issues I'd like to see resolved before this gets merged. Thanks again for taking the time to contribute, I do appreciate the patience it takes. |
|
Hi Tim |
|
On further inspection, perhaps those async blocks in df0505c were a good idea. It just looked strange when I looked at them first -- up to you if you want to un-revert. What you have looks pretty good, but it's also a major change so I'm going to take my time merging it in. |
|
Yes they maybe can simply reading of code, but at the end the code is executed synchronously, maybe i could readd them later. |
Hi i have updated to new shining mongodb driver :), and also with the last F# runtime, let me know if you like it or if i should improve something