Remove unnecessary WKWebView/UIWebview logic#2
Open
josh-m-sharpe wants to merge 1 commit intotlacroix:masterfrom
Open
Remove unnecessary WKWebView/UIWebview logic#2josh-m-sharpe wants to merge 1 commit intotlacroix:masterfrom
josh-m-sharpe wants to merge 1 commit intotlacroix:masterfrom
Conversation
Owner
|
Hi @josh-m-sharpe, thanks for following up with your PR on the original project. I looked at it just after I submitted mine (on Telerik's repo), and it seemed a lot cleaner. I'll just need a bit of time to test it with a few of my apps before I merge it since there's no automated testing, but just by looking at the code, I'm 99.999% sure everything's fine. Thanks again! |
Owner
|
Tested and all good. Just one change request, since your PR removes all support for UIWebView: Please add, in plugin.xml: |
Author
|
@tlacroix would you mind adding/testing that bit? I don't use cordova, so I have no means to test/confirm that part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from our convo here:
Telerik-Verified-Plugins#185
This PR merges in the changes I was making in that PR, which pretty much does the same thing, but also removes some additional unnecessary logic.