[AI] Fix DTLS config override issue with finishWithCloseNotify#223
Open
[AI] Fix DTLS config override issue with finishWithCloseNotify#223
Conversation
When using -version DTLS12 parameter, finishWithCloseNotify was always set to true, overriding any XML configuration. This fix: - Removes automatic setting of finishWithCloseNotify in ProtocolVersionDelegate for DTLS - Adds new -close_notify parameter to explicitly control this setting - Preserves backward compatibility while allowing XML config to work as expected Fixes #182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-version DTLS12parameter always setsfinishWithCloseNotifyto true, overriding XML configuration-close_notifyparameter for explicit control of this setting-versionparameterChanges
finishWithCloseNotifyfor DTLS versions-close_notifyparameter explicitlyTest plan
Usage
Users can now:
<finishWithCloseNotify>false</finishWithCloseNotify>works with-version DTLS12-close_notify true/falseto override any config settingFixes #182