[AI] Fix: DTLS finishWithCloseNotify override issue (#182)#224
Open
[AI] Fix: DTLS finishWithCloseNotify override issue (#182)#224
Conversation
Remove automatic setting of finishWithCloseNotify to true when using -version DTLS* parameter. This allows users to control the finishWithCloseNotify setting via configuration file as intended.
ic0ns
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finishWithCloseNotifyto true when using-version DTLS*parameterfinishWithCloseNotifysetting via configuration file as intendedDetails
The issue occurred because the
ProtocolVersionDelegatewas unconditionally settingfinishWithCloseNotifyto true for all DTLS versions, overriding any value set in the configuration file. This made it impossible for users to disable the close notify alert when using DTLS.The fix is simple: remove the line that sets this value, allowing the configuration file setting to be respected.
Test plan
finishWithCloseNotifyconfiguration is respected for DTLS versionstrueandfalsevalues are preserved when set in config