Conversation
…rtcut syntax Co-authored-by: tmichoel <11647967+tmichoel@users.noreply.github.com>
remake for ConstantRateBranchingProblem with inner-problem shortcut syntax
tmichoel
left a comment
There was a problem hiding this comment.
- Add tests for the remake function where the problem (
probfield of the branching problem) is a JumpProblem instead of an SDEProblem - Replace all calls to
remake_initial_conditionby appropriate calls to the newremakefunction. - Mark
remake_initial_conditionas deprecated
… deprecate remake_initial_condition Co-authored-by: tmichoel <11647967+tmichoel@users.noreply.github.com>
Done in b6f28a5:
A private Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
tmichoel
left a comment
There was a problem hiding this comment.
The SciML remake function for a JumpProblem prob appears to already implement the shortcut that updating a parameter such as the initial condition updates the inner prob.prob field, see https://docs.sciml.ai/JumpProcesses/stable/jump_types/#Remaking-JumpProblems. Confirm this and remove the _remake_inner_prob function if it is indeed not needed.
…em kwargs natively Co-authored-by: tmichoel <11647967+tmichoel@users.noreply.github.com>
Confirmed — Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
tmichoel
left a comment
There was a problem hiding this comment.
Parse the src subdirectory of the docs directory of the project and update the markdown documents to reflect the proposed changes to the codebase.
… to Deprecated section Co-authored-by: tmichoel <11647967+tmichoel@users.noreply.github.com>
Done in 108c15e. Updated |
Adds
SciMLBase.remakesupport forConstantRateBranchingProblem, following the DifferentialEquations.jl convention. Includes a shortcut syntax that forwards unrecognized kwargs toSciMLBase.remakeon the inner single-particle dynamics problem, working uniformly for bothSDEProblemandJumpProbleminner problems (the latter already supports shortcut kwargs likeu0andtspannatively via the JumpProcesses.jl remake implementation).Changes
src/solvers.jl:SciMLBase.remakemethod acceptingprob,lifetime, andnchildfor direct field replacement; any other kwargs (e.g.u0,tspan,p) are passed toSciMLBase.remake(bp.prob; kwargs...)to modify the inner single-particle dynamics problem.solve_and_split(bp::ConstantRateBranchingProblem, alg; kwargs...)overload that usesremake(bp, ...)internally instead ofremake_initial_condition. The oldsolve_and_split(prob, lifetime, nchild, alg; kwargs...)signature is kept for backward compatibility and delegates to the new overload.remake_initial_conditionmarked as deprecated (withBase.depwarnand docstring warning).src/BranchingProcesses.jl: Exportsremaketest/runtests.jl: Tests for all remake combinations for bothSDEProblemandJumpProbleminner problemsProject.toml: AddedJumpProcessesas a test dependencydocs/src/solvers.md: Addedremaketo the Solvers documentation page; movedremake_initial_conditionto a separate "Deprecated" sectionUsage
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.