Conversation
system-x/services/ai/qdrant/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.apache.httpcomponents.client5</groupId> | ||
| <artifactId>httpclient5</artifactId> | ||
| <version>5.2.1</version> |
There was a problem hiding this comment.
why do you keep adding a 3 year old http client version in every service when the whole TNB already contains a http client?
https://github.com/tnb-software/TNB/blob/main/common/pom.xml#L35-L38
https://github.com/tnb-software/TNB/blob/main/common/src/main/java/software/tnb/common/utils/HTTPUtils.java
There was a problem hiding this comment.
On our final test-suite (tnb-tests) we are using <httpclient5.version>5.1.4</httpclient5.version> ... About existing http client, do you mean okhttp3? Migrate to this one, shouldn't be a problem
| this.baseUrl = baseUrl; | ||
| } | ||
|
|
||
| public boolean isHealthy() { |
There was a problem hiding this comment.
how do you use this method? there is a way how to create a liveness/readiness probes for the openshift deployments and you already wait for this endpoint in the local container
There was a problem hiding this comment.
I noticed that those APIs are valid for containers as well, even if declared for Kubernetes.
So they can be used for OCP, or Local. There's also the change to to use /readyz or /livez. For me, the important thing was to verify that the service was completely started
|
Dependency changes
Diffsystem-x-all--- a/base/system-x-all
+++ b/head/system-x-all
@@ -561,6 +561,7 @@ The following files have been resolved:
software.tnb:system-x-opentelemetry:jar:1.0-SNAPSHOT:compile�[36m -- module system.x.opentelemetry�[0;1;33m (auto)�[m
software.tnb:system-x-postgresql:jar:1.0-SNAPSHOT:compile�[36m -- module system.x.postgresql�[0;1;33m (auto)�[m
software.tnb:system-x-prometheus:jar:1.0-SNAPSHOT:compile�[36m -- module system.x.prometheus�[0;1;33m (auto)�[m
+ software.tnb:system-x-qdrant:jar:1.0-SNAPSHOT:compile�[36m -- module system.x.qdrant�[0;1;33m (auto)�[m
software.tnb:system-x-rabbitmq:jar:1.0-SNAPSHOT:compile�[36m -- module system.x.rabbitmq�[0;1;33m (auto)�[m
software.tnb:system-x-redis:jar:1.0-SNAPSHOT:compile�[36m -- module system.x.redis�[0;1;33m (auto)�[m
software.tnb:system-x-rest:jar:1.0-SNAPSHOT:compile�[36m -- module system.x.rest�[0;1;33m (auto)�[msystem-x-qdrant--- /dev/null
+++ b/head/system-x-qdrant
@@ -0,0 +1,128 @@
+
+The following files have been resolved:
+ com.bettercloud:vault-java-driver:jar:5.1.0:compile�[36m -- module vault.java.driver�[m
+ com.fasterxml.jackson.core:jackson-annotations:jar:2.20:compile�[36m -- module com.fasterxml.jackson.annotation�[m
+ com.fasterxml.jackson.core:jackson-core:jar:2.20.0:compile�[36m -- module com.fasterxml.jackson.core�[m
+ com.fasterxml.jackson.core:jackson-databind:jar:2.20.0:compile�[36m -- module com.fasterxml.jackson.databind�[m
+ com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.20.0:compile�[36m -- module com.fasterxml.jackson.dataformat.yaml�[m
+ com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.20.0:compile�[36m -- module com.fasterxml.jackson.datatype.jsr310�[m
+ com.github.docker-java:docker-java-api:jar:3.7.0:compile�[36m -- module com.github.dockerjava.api�[0;1m [auto]�[m
+ com.github.docker-java:docker-java-transport-zerodep:jar:3.7.0:compile�[36m -- module com.github.dockerjava.transport.zerodep�[0;1m [auto]�[m
+ com.github.docker-java:docker-java-transport:jar:3.7.0:compile�[36m -- module com.github.dockerjava.transport�[0;1m [auto]�[m
+ com.google.auto.service:auto-service-annotations:jar:1.1.0:compile�[36m -- module com.google.auto.service�[0;1m [auto]�[m
+ com.google.code.findbugs:jsr305:jar:3.0.2:compile�[36m -- module jsr305�[0;1;33m (auto)�[m
+ com.google.errorprone:error_prone_annotations:jar:2.18.0:compile�[36m -- module com.google.errorprone.annotations�[0;1m [auto]�[m
+ com.google.guava:failureaccess:jar:1.0.1:compile�[36m -- module failureaccess�[0;1;33m (auto)�[m
+ com.google.guava:guava:jar:32.0.1-jre:compile�[36m -- module com.google.common�[0;1m [auto]�[m
+ com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile�[36m -- module listenablefuture�[0;1;33m (auto)�[m
+ com.google.j2objc:j2objc-annotations:jar:2.8:compile�[36m -- module j2objc.annotations�[0;1;33m (auto)�[m
+ com.googlecode.javaewah:JavaEWAH:jar:1.1.13:compile�[36m -- module JavaEWAH�[0;1;33m (auto)�[m
+ com.squareup.okhttp3:logging-interceptor:jar:4.11.0:compile�[36m -- module okhttp3.logging�[0;1m [auto]�[m
+ com.squareup.okhttp3:okhttp:jar:4.11.0:compile�[36m -- module okhttp3�[0;1m [auto]�[m
+ com.squareup.okio:okio-jvm:jar:3.2.0:compile�[36m -- module okio�[0;1m [auto]�[m
+ com.squareup.okio:okio:jar:3.2.0:compile�[36m -- module okio�[0;1;33m (auto)�[m
+ commons-codec:commons-codec:jar:1.15:compile�[36m -- module org.apache.commons.codec�[0;1m [auto]�[m
+ commons-io:commons-io:jar:2.21.0:compile�[36m -- module org.apache.commons.io�[m
+ cz.xtf:core:jar:1.0:compile�[36m -- module core�[0;1;33m (auto)�[m
+ io.fabric8:knative-client:jar:7.5.0:compile�[36m -- module knative.client�[0;1;33m (auto)�[m
+ io.fabric8:knative-model:jar:7.5.0:compile�[36m -- module knative.model�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-client-api:jar:7.5.0:compile�[36m -- module kubernetes.client.api�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-client:jar:7.5.0:compile�[36m -- module kubernetes.client�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-httpclient-vertx:jar:7.5.0:runtime�[36m -- module kubernetes.httpclient.vertx�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-admissionregistration:jar:7.5.0:compile�[36m -- module kubernetes.model.admissionregistration�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-apiextensions:jar:7.5.0:compile�[36m -- module kubernetes.model.apiextensions�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-apps:jar:7.5.0:compile�[36m -- module kubernetes.model.apps�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-autoscaling:jar:7.5.0:compile�[36m -- module kubernetes.model.autoscaling�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-batch:jar:7.5.0:compile�[36m -- module kubernetes.model.batch�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-certificates:jar:7.5.0:compile�[36m -- module kubernetes.model.certificates�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-common:jar:7.5.0:compile�[36m -- module kubernetes.model.common�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-coordination:jar:7.5.0:compile�[36m -- module kubernetes.model.coordination�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-core:jar:7.5.0:compile�[36m -- module kubernetes.model.core�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-discovery:jar:7.5.0:compile�[36m -- module kubernetes.model.discovery�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-events:jar:7.5.0:compile�[36m -- module kubernetes.model.events�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-extensions:jar:7.5.0:compile�[36m -- module kubernetes.model.extensions�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-flowcontrol:jar:7.5.0:compile�[36m -- module kubernetes.model.flowcontrol�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-gatewayapi:jar:7.5.0:compile�[36m -- module kubernetes.model.gatewayapi�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-metrics:jar:7.5.0:compile�[36m -- module kubernetes.model.metrics�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-networking:jar:7.5.0:compile�[36m -- module kubernetes.model.networking�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-node:jar:7.5.0:compile�[36m -- module kubernetes.model.node�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-policy:jar:7.5.0:compile�[36m -- module kubernetes.model.policy�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-rbac:jar:7.5.0:compile�[36m -- module kubernetes.model.rbac�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-resource:jar:7.5.0:compile�[36m -- module kubernetes.model.resource�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-scheduling:jar:7.5.0:compile�[36m -- module kubernetes.model.scheduling�[0;1;33m (auto)�[m
+ io.fabric8:kubernetes-model-storageclass:jar:7.5.0:compile�[36m -- module kubernetes.model.storageclass�[0;1;33m (auto)�[m
+ io.fabric8:openshift-client-api:jar:7.5.0:compile�[36m -- module openshift.client.api�[0;1;33m (auto)�[m
+ io.fabric8:openshift-client:jar:7.5.0:compile�[36m -- module openshift.client�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-autoscaling:jar:7.5.0:compile�[36m -- module openshift.model.autoscaling�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-config:jar:7.5.0:compile�[36m -- module openshift.model.config�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-console:jar:7.5.0:compile�[36m -- module openshift.model.console�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-hive:jar:7.5.0:compile�[36m -- module openshift.model.hive�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-installer:jar:7.5.0:compile�[36m -- module openshift.model.installer�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-machine:jar:7.5.0:compile�[36m -- module openshift.model.machine�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-machineconfiguration:jar:7.5.0:compile�[36m -- module openshift.model.machineconfiguration�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-miscellaneous:jar:7.5.0:compile�[36m -- module openshift.model.miscellaneous�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-monitoring:jar:7.5.0:compile�[36m -- module openshift.model.monitoring�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-operator:jar:7.5.0:compile�[36m -- module openshift.model.operator�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-operatorhub:jar:7.5.0:compile�[36m -- module openshift.model.operatorhub�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-storageversionmigrator:jar:7.5.0:compile�[36m -- module openshift.model.storageversionmigrator�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-tuned:jar:7.5.0:compile�[36m -- module openshift.model.tuned�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model-whereabouts:jar:7.5.0:compile�[36m -- module openshift.model.whereabouts�[0;1;33m (auto)�[m
+ io.fabric8:openshift-model:jar:7.5.0:compile�[36m -- module openshift.model�[0;1;33m (auto)�[m
+ io.fabric8:zjsonpatch:jar:7.5.0:compile�[36m -- module zjsonpatch�[0;1;33m (auto)�[m
+ io.netty:netty-buffer:jar:4.1.125.Final:runtime�[36m -- module io.netty.buffer�[0;1m [auto]�[m
+ io.netty:netty-codec-dns:jar:4.1.125.Final:runtime�[36m -- module io.netty.codec.dns�[0;1m [auto]�[m
+ io.netty:netty-codec-http2:jar:4.1.125.Final:runtime�[36m -- module io.netty.codec.http2�[0;1m [auto]�[m
+ io.netty:netty-codec-http:jar:4.1.125.Final:runtime�[36m -- module io.netty.codec.http�[0;1m [auto]�[m
+ io.netty:netty-codec-socks:jar:4.1.125.Final:runtime�[36m -- module io.netty.codec.socks�[0;1m [auto]�[m
+ io.netty:netty-codec:jar:4.1.125.Final:runtime�[36m -- module io.netty.codec�[0;1m [auto]�[m
+ io.netty:netty-common:jar:4.1.125.Final:runtime�[36m -- module io.netty.common�[0;1m [auto]�[m
+ io.netty:netty-handler-proxy:jar:4.1.125.Final:runtime�[36m -- module io.netty.handler.proxy�[0;1m [auto]�[m
+ io.netty:netty-handler:jar:4.1.125.Final:runtime�[36m -- module io.netty.handler�[0;1m [auto]�[m
+ io.netty:netty-resolver-dns:jar:4.1.125.Final:runtime�[36m -- module io.netty.resolver.dns�[0;1m [auto]�[m
+ io.netty:netty-resolver:jar:4.1.125.Final:runtime�[36m -- module io.netty.resolver�[0;1m [auto]�[m
+ io.netty:netty-transport-native-unix-common:jar:4.1.125.Final:runtime�[36m -- module io.netty.transport.unix.common�[0;1m [auto]�[m
+ io.netty:netty-transport:jar:4.1.125.Final:runtime�[36m -- module io.netty.transport�[0;1m [auto]�[m
+ io.reactivex:rxjava-string:jar:1.1.1:compile�[36m -- module rxjava.string�[0;1;33m (auto)�[m
+ io.reactivex:rxjava:jar:1.3.8:compile�[36m -- module rxjava�[0;1;33m (auto)�[m
+ io.smallrye.common:smallrye-common-annotation:jar:2.15.0:compile�[36m -- module io.smallrye.common.annotation�[m
+ io.smallrye.common:smallrye-common-classloader:jar:2.15.0:compile�[36m -- module io.smallrye.common.classloader�[m
+ io.smallrye.common:smallrye-common-constraint:jar:2.15.0:compile�[36m -- module io.smallrye.common.constraint�[m
+ io.smallrye.common:smallrye-common-expressionSee the full diff from https://github.com/tnb-software/TNB/actions/runs/22896874362 |
No description provided.