Add GPG verification, default to latest, and CI #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify the GPG signature of downloaded AWS CLI packages using the official AWS CLI public key, as recommended in the AWS documentation. - Add AWS CLI public key (files/aws-cli-public-key.asc) - Add verify_signature parameter (defaults to true) - Download signature file and verify before extraction - Use isolated gpg keyring to avoid affecting user's keyring - Requires gpg and unzip packages when verification is enabled - Fall back to direct extraction when verification is disabled See: https://docs.aws.amazon.com/cli/latest/userguide/getting-started-install.html 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change version parameter from required to optional, defaulting to 'latest' which always installs/upgrades to the latest available AWS CLI version. - Use non-versioned download URL when version is 'latest' - Always attempt upgrade when version is 'latest' (installer handles idempotency) - Skip old version cleanup when using 'latest' (version unknown at compile time) - Update documentation with new default behavior and examples 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename module to tobixen-awscli2 - Update author, source, project_page, and issues_url - Add Ubuntu 20.04 and 24.04 to supported operating systems - Expand RedHat support to versions 7, 8, 9 - Bump Puppet requirement to support Puppet 8 - Add fork attribution with link to original umd/awscli2 module - Document fork changes in README 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add comprehensive spec tests for the awscli2 module: - Test default parameters with 'latest' version - Test GPG signature verification (enabled by default) - Test verify_signature => false option - Test specific version installation - Test custom install_dir and bin_dir parameters - Test ensure => absent for uninstall CI configuration: - Run puppet-lint for code style checking - Run rspec-puppet tests on Puppet 7 and 8 - Use appropriate Ruby versions for each Puppet version 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
tobixen
force-pushed
the
feature/gpg-verification-and-latest-version
branch
from
f25e761 to
36d8cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
versionparameter now defaults to'latest'for automatic updatesChanges
Security
files/aws-cli-public-key.asc).sigfile before extractionverify_signatureparameter (defaults totrue)gpgandunzipwhen verification is enabledUsability
versionparameter now optional, defaults to'latest''latest''latest'(installer handles idempotency)Metadata
tobixen-awscli2< 9.0.00.4.0Testing
Test plan
verify_signature => false🤖 Generated with Claude Code